Use JSON serialization for deep map copy

scastria · Jun 26, 2023 · 0653dee · 0653dee
1 parent a52a356
commit 0653dee
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/konnect/resource_plugin.go b/konnect/resource_plugin.go
@@ -247,7 +247,7 @@ func resourcePluginCreate(ctx context.Context, d *schema.ResourceData, m interfa
 		d.SetId("")
 		return diag.FromErr(err)
 	}
-	retVal.ConfigAll = copyMap(retVal.Config)
+	retVal.ConfigAll = copyMapByJSON(retVal.Config)
 	retVal.RuntimeGroupId = newPlugin.RuntimeGroupId
 	d.SetId(retVal.PluginEncodeId())
 	fillResourceDataFromPlugin(ctx, retVal, d, pluginSchema)
@@ -279,7 +279,7 @@ func resourcePluginRead(ctx context.Context, d *schema.ResourceData, m interface
 		d.SetId("")
 		return diag.FromErr(err)
 	}
-	retVal.ConfigAll = copyMap(retVal.Config)
+	retVal.ConfigAll = copyMapByJSON(retVal.Config)
 	retVal.RuntimeGroupId = runtimeGroupId
 	fillResourceDataFromPlugin(ctx, retVal, d, pluginSchema)
 	return diags
@@ -313,7 +313,7 @@ func resourcePluginUpdate(ctx context.Context, d *schema.ResourceData, m interfa
 	if err != nil {
 		return diag.FromErr(err)
 	}
-	retVal.ConfigAll = copyMap(retVal.Config)
+	retVal.ConfigAll = copyMapByJSON(retVal.Config)
 	retVal.RuntimeGroupId = runtimeGroupId
 	fillResourceDataFromPlugin(ctx, retVal, d, pluginSchema)
 	return diags

diff --git a/konnect/utils.go b/konnect/utils.go
@@ -1,6 +1,7 @@
 package konnect
 
 import (
+	"encoding/json"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"reflect"
 )
@@ -39,10 +40,9 @@ func removeNulls(m map[string]interface{}) {
 	}
 }
 
-func copyMap[K string, V interface{}](m map[K]V) map[K]V {
+func copyMapByJSON[K string, V interface{}](m map[K]V) map[K]V {
+	bytes, _ := json.Marshal(m)
 	result := make(map[K]V)
-	for k, v := range m {
-		result[k] = v
-	}
+	json.Unmarshal(bytes, &result)
 	return result
 }