Skip to content

Commit

Permalink
Update CI Versions
Browse files Browse the repository at this point in the history
It's time for everyone's favorite game: bump the versions! Ruby 3.4 is
out, and Rails 8 has been shipped for some time. We try to keep our CI
suite testing currently-supported versions of each, but we don't want a
giant matrix that requires many customizations to run successfully
either.

As a result, this commit:

* Adds testing our full matrix with Ruby 3.4
* Drops testing with Ruby 3.1
* Drops testing with Rails 7.1

I think this is a good balance of testing the latest versions of Ruby
and Rails while maintaining some backward compatibility in a manner that
doesn't require a degree in YAML to understand.
  • Loading branch information
derekprior committed Dec 29, 2024
1 parent d504b40 commit 6e2bdba
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 7 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,11 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ["3.2", "3.3"]
rails: ["7.1", "7.2"]
ruby: ["3.4", "3.3"]
rails: ["8.0", "7.2"]
continue-on-error: [false]
include:
- ruby: "head"
rails: "7.2"
continue-on-error: true
- ruby: "3.3"
- ruby: "3.4"
rails: "main"
continue-on-error: true
- ruby: "head"
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ tmp
gemfiles/*.lock
.DS_Store
.ruby-version
.vscode/
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ source "https://rubygems.org"
# Specify your gem's dependencies in scenic.gemspec
gemspec

rails_version = ENV.fetch("RAILS_VERSION", "7.0")
rails_version = ENV.fetch("RAILS_VERSION", "8.0")

rails_constraint = if rails_version == "main"
{github: "rails/rails"}
Expand Down
4 changes: 4 additions & 0 deletions spec/dummy/config/application.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,9 @@ class Application < Rails::Application
config.cache_classes = true
config.eager_load = false
config.active_support.deprecation = :stderr

if config.active_support.respond_to?(:to_time_preserves_timezone)
config.active_support.to_time_preserves_timezone = :zone
end
end
end

0 comments on commit 6e2bdba

Please sign in to comment.