Set pitch wheel back to center on all_ctrl_off #119
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making a midi player, so have been testing out various midi files.
I came across one that had a pitch bend that was meant to return to center.
One control change it was getting producing was 0x79 (121) for resetting all controls.
On Windows Media Player, it sounded fine but not in the midi player i was writing which was calling
tsf_channel_midi_controlfor this particular event.After making this change, the midi playback now sounds fine, and the pitch bending heard in windows media player sounded identical to my ears.
Without this change, the pitch would bend, and then stay bent until another pitch bend event.
Let me know if you need any further examples, or a video demo showing the before/after.