Conversation
mukarramali
added
the
hacktoberfest-accepted
| "scripts": { | ||
| "start": "node index.js", | ||
| "dev": "env-cmd -f .env nodemon index.js", | ||
| "start": "node dist", |
There was a problem hiding this comment.
We have auto deployments for Vacabot app using heroku.
And there we have configured npm start as the running script.
There was a problem hiding this comment.
Which means, this dist has to be created before running
There was a problem hiding this comment.
@mukarramali Can you Check once i think heroku builds automatically before deployments.
https://devcenter.heroku.com/changelog-items/1557
There was a problem hiding this comment.
that's great.
But we don't have build script in package.json.
You wanna add that?
There was a problem hiding this comment.
@mukarramali In the PR i have already added the build script. PR is good to go.
There was a problem hiding this comment.
Turns out babel didn't pick the environment variables.
To test it in your machine, you can first creat .env file as told in README. And then do build and start.
It should through an error as expected env variables aren't present.
mukarramali
left a comment
mukarramali
left a comment
There was a problem hiding this comment.
Code changes look good. Just see the running script.
| "scripts": { | ||
| "start": "node index.js", | ||
| "dev": "env-cmd -f .env nodemon index.js", | ||
| "start": "node dist", |
There was a problem hiding this comment.
that's great.
But we don't have build script in package.json.
You wanna add that?
2 participants
No description provided.