Merge pull request #46 from adrienbrault/gh-44

Fix NullMetadata performance issue
schmittjoh · Jul 12, 2014 · 22b7245 · 22b7245
2 parents 72091ba + cc1f2b8
commit 22b7245
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 15 deletions.
diff --git a/src/Metadata/MetadataFactory.php b/src/Metadata/MetadataFactory.php
@@ -112,12 +112,12 @@ public function getMetadataForClass($className)
             }
 
             if (null !== $this->cache && !$this->debug) {
-                $this->cache->putClassMetadataInCache(new NullMetadata());
+                $this->cache->putClassMetadataInCache(new NullMetadata($class->getName()));
             }
         }
 
         if (null === $metadata) {
-            $metadata = new NullMetadata();
+            $metadata = new NullMetadata($className);
         }
 
         return $this->filterNullMetadata($this->loadedMetadata[$className] = $metadata);

diff --git a/src/Metadata/NullMetadata.php b/src/Metadata/NullMetadata.php
@@ -9,18 +9,5 @@
  */
 class NullMetadata extends ClassMetadata
 {
-    public function __construct()
-    {
 
-    }
-
-    public function serialize()
-    {
-        return '';
-    }
-
-    public function unserialize($str)
-    {
-
-    }
 }