Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow int and null as possible types for $key in Option::fromArraysValue #74

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

niconoe-
Copy link
Contributor

@niconoe- niconoe- commented Feb 7, 2024

Closes #73.

@GrahamCampbell GrahamCampbell changed the title Fix #73: allow int and null as possible types for $key in Option::fromArraysValue Allow int and null as possible types for $key in Option::fromArraysValue Jul 20, 2024
@GrahamCampbell GrahamCampbell merged commit e3fac8b into schmittjoh:master Jul 20, 2024
10 of 11 checks passed
@GrahamCampbell
Copy link
Collaborator

Thanks!

@niconoe- niconoe- deleted the fix/73 branch July 20, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option::fromArraysValue should have parameter $key typed as int|string (and possibly null|int|string)
2 participants