Fix serialization of BackedEnum - annotation without name/value #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iKsSs
changed the title
|
@goetas could you help with review, please? :) |
|
Looks good to me. I'm surprised that i forgot to implement it from get go. i have left only one minor comment |
goetas
reviewed
Feb 19, 2024
src/Handler/EnumHandler.php
Outdated
| @@ -44,7 +44,7 @@ public function serializeEnum( | |||
| array $type, | |||
| SerializationContext $context | |||
| ) { | |||
| if (isset($type['params'][1]) && 'value' === $type['params'][1]) { | |||
| if ((isset($type['params'][1]) && 'value' === $type['params'][1]) || (!isset($type['params'][1]) && is_a($enum, \BackedEnum::class, true))) { | |||
There was a problem hiding this comment.
Can is_a($enum, \BackedEnum::class, true) be replace with $enum instanceof \BackedEnum? seems much more readable to me.
There was a problem hiding this comment.
thanks for reviewing the code...
yes, instanceof is better here 👍
scyzoryck
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialization of Backed Enum, when property has Serializer annotation with specified Enum Class but second parameter (name/value), is not provided was not behaving according to documentation.