Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelfPortal - Add filtering to only see compatible packages & force reinstall #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thorm42
Copy link

@thorm42 thorm42 commented Dec 16, 2024

No description provided.

@thorm42 thorm42 changed the title Add filtering to only see compatible packages SelfPortal - Add filtering to only see compatible packages & force reinstall Dec 16, 2024
@schorschii
Copy link
Owner

Hi, thanks for your contribution.

The problem with your implementation is that packages now will appear multiple times if the user has multiple computers due to your foreach($myComputers as $computer) loop. Can you please fix this? Please note that multiple operating systems are allowed too (comma separated) and the OS version should be checked too. If the os and os_version of the package is empty, the package should be treat as compatible for all platforms. You can use the already existing functions isOsCompatible() and isOsVersionCompatible() for that.

I'm not a fan of overwriting $forceInstallSameVersion in the deploySelfService() function. Instead, I'd like to make this configurable similar to the job priority, see here.

Please also use tabs instead of spaces for indentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants