-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add atom object name on the cmd.get_model()
returned model
#380
Add atom object name on the cmd.get_model()
returned model
#380
Conversation
Aside from the compilation errors, I'm wondering if this is the right approach. Wouldn't each atom's object name be duplicated (wasted space)? Would it make sense to have the name be stored per-object/model rather than per-atom? |
1de7c8b
to
60758f4
Compare
I had this doubt and thought that And I'm not sure if the same happens when the string is built from the C API, but Python's strings of the same value share the same memory space. |
I decided to return the object name on the atom model because it's convenient. It would be even more if it worked on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just mostly one suggestion regarding variable usage.
I take back my comment regarding having model
on the model
level since I was under the impression these were exported as separate models, but this probably makes the most sense to align w/ iterate.
e6025de
to
ab151df
Compare
Thanks for the PR! |
Now
cmd.get_model()
returns an atom model with the object name on it. I didn't want to use theobject
variable because it is a built-in, however I thought that any other name would be misleading.