Query available commands and change backup format #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hard-coding commands for query and backup, ask the device which commands it supports using osc/schema requests.
Instead of a list of command strings, store data in backup as json object hierarchy. This reflects the structure of the commands better and improves interoperability with other tools.
LeanderBlume
force-pushed
the
query-available-commands
branch
from
a50dc94 to
69da744
Compare
Contributor
Author
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
khtool_commands.jsonosc/limitsdata for each parameter. This is used to check writability of parameters and could be used by external tools to check acceptable ranges, units etc.--backup. They now store device parameters in a json object hierarchy instead of a list of command strings. This better reflects the structure of the parameters better and improves interoperability with other tools.TODOs
device.ipinstead ofdevice.nameinkhtool_commands.json? Probably yes, if only to keep consistent with--backupbehavior._query_by_dictcurrently populates the command dictionary with values and returns the corresponding list of command strings. This might be confusing. Split up?restore_devicenext tobackup_device.