Skip to content

[Snyk] Fix for 3 vulnerabilities #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertatakenaka wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Fix for 3 vulnerabilities #785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions requirements/local.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,5 @@ django-extensions==3.2.3 # https://github.com/django-extensions/django-extensio
django-coverage-plugin==3.1.0 # https://github.com/nedbat/django_coverage_plugin
pytest-django==4.7.0 # https://github.com/pytest-dev/pytest-django
tornado>=6.4.1 # not directly required, pinned by Snyk to avoid a vulnerability
django>=4.2.27 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment 'not directly required' is misleading. Django is a direct dependency (used by django-extensions 3.2.3 as shown in the warning), and this version constraint may conflict with existing Django version specifications elsewhere in the requirements. Consider consolidating Django version requirements into a single, explicit entry in the appropriate requirements file (base.txt or production.txt) rather than using '>=', which could lead to unpredictable version resolution.

Suggested change
django>=4.2.27 # not directly required, pinned by Snyk to avoid a vulnerability

Copilot uses AI. Check for mistakes.
sqlparse>=0.5.4 # not directly required, pinned by Snyk to avoid a vulnerability
Comment on lines +40 to +41
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using '>=' constraints for security fixes in a local development requirements file is problematic. This approach allows any future version (including potentially incompatible major versions like Django 5.x) and doesn't guarantee these constraints apply to production. Security fixes should use exact version pinning (==) or restricted ranges (e.g., >=4.2.27,<5.0) and be placed in the base or production requirements file to ensure they're enforced across all environments.

Copilot uses AI. Check for mistakes.