Skip to content

Commit

Permalink
🐛 Ensure multiple? method is called correctly for new and existing re…
Browse files Browse the repository at this point in the history
…cords

fix: Ensure multiple? method is called correctly for new and existing records

- Updated the view logic to check if the instance responds to `multiple?` first.
- If the instance does not respond, then check if the class responds to `multiple?`.
- This ensures the correct method is called for both new and existing records, preventing method undefined errors.
  • Loading branch information
ShanaLMoore committed Jul 22, 2024
1 parent cfa48b3 commit 5e0148e
Show file tree
Hide file tree
Showing 16 changed files with 16 additions and 16 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% # use date picker %>
<% if f.object.class.multiple? key %>
<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %>
<%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
<% else %>
<%= f.input key, input_html: { value: f.object.model[key]&.first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/records/edit_fields/_date_accepted.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% # use date picker %>
<% if f.object.class.multiple? key %>
<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %>
<%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
<% else %>
<%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/records/edit_fields/_date_available.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% # use date picker %>
<% if f.object.class.multiple? key %>
<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %>
<%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
<% else %>
<%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/records/edit_fields/_date_collected.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% # use date picker %>
<% if f.object.class.multiple? key %>
<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %>
<%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
<% else %>
<%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/records/edit_fields/_date_copyrighted.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% # use date picker %>
<% if f.object.class.multiple? key %>
<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %>
<%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
<% else %>
<%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/records/edit_fields/_date_created.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<%# use date picker %>
<% if f.object.class.multiple? key %>
<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %>
<%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
<% else %>
<%= f.input key, input_html: { value: f.object.model[key]&.first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/records/edit_fields/_date_issued.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% # use date picker %>
<% if f.object.class.multiple? key %>
<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %>
<%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
<% else %>
<%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/records/edit_fields/_date_of_award.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% # use date picker %>
<% if f.object.class.multiple? key %>
<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %>
<%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
<% else %>
<%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/records/edit_fields/_date_published.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% # use date picker %>
<% if f.object.class.multiple? key %>
<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %>
<%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
<% else %>
<%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/records/edit_fields/_date_submitted.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% # use date picker %>
<% if f.object.class.multiple? key %>
<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %>
<%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
<% else %>
<%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/records/edit_fields/_date_updated.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% # use date picker %>
<% if f.object.class.multiple? key %>
<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %>
<%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
<% else %>
<%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/records/edit_fields/_date_valid.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% # use date picker %>
<% if f.object.class.multiple? key %>
<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %>
<%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
<% else %>
<%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/records/edit_fields/_default.html.erb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<% # the hyrax version of this file messes singular field display %>
<% if f.object.class.multiple?(key) %>
<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %>
<%= f.input key, as: :multi_value, input_html: { class: 'form-control' }, required: f.object.required?(key) %>
<% else %>
<% value = f.object.model[key] %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/records/edit_fields/_end_date.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% # use date picker %>
<% if f.object.class.multiple? key %>
<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %>
<%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
<% else %>
<%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/records/edit_fields/_event_date.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% # use date picker %>
<% if f.object.class.multiple? key %>
<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %>
<%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
<% else %>
<%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/records/edit_fields/_start_date.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% # use date picker %>
<% if f.object.class.multiple? key %>
<% f.object.try(:multiple?, key) || f.object.class.try(:multiple?, key) %>
<%= f.input key, as: :multi_value, input_html: { data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
<% else %>
<%= f.input key, input_html: { value: f.object.model[key].first, data: { provide: 'datepicker', 'date-force-parse': 'false', 'date-autoclose': 'true' } }, required: f.object.required?(key) %>
Expand Down

0 comments on commit 5e0148e

Please sign in to comment.