Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection branding doesn't work #797

Open
8 tasks
Tracked by #768 ...
ShanaLMoore opened this issue Sep 11, 2024 · 2 comments
Open
8 tasks
Tracked by #768 ...

Collection branding doesn't work #797

ShanaLMoore opened this issue Sep 11, 2024 · 2 comments
Assignees
Labels
bug something isn't working M1 Milestone 1

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Sep 11, 2024

Summary

Update re: collection branding. ref

Team, I know that the banners are broken on collection pages (or at least they have been in our instance from day one). Logos used to work on production, but in staging I tested and the logo will upload but then the page is frozen. It won't even save and update to show me if the logo renders properly. I just tested with the following collection, but it won't save my changes, so you won't see much if you go there I'm afraid: https://adl.s2.adventistdigitallibrary.org/dashboard/collections/ebbab001-fd0c-40f2-ab26-eebab8808392/edit?locale=en#branding

I tested all the branding options and none of them work on staging post-Valkyrie. We'd like the logos to work at least, if possible.

Acceptance Criteria

  • Uploading images on the branding tabs should display them on the collection public show page, for
    • logo
    • banner
    • thumbnail
  • alt text and url appear if entered for branding images

Screenshots or Video

Image

Testing Instructions

On Staging, find this collection in admin dashboard > collections
Click on edit
go to the branding tab, upload an image for

  • banner

  • logo

  • thumbnail

  • alt text

  • url (must include http:// portion)
    click save
    click into the collection
    click 'Public view of Collection'

  • your imported images should be all be viewable from this page

  • your alt text should be viewable via inspect in the generated html

  • clicking on the logo should open the url you entered

image

Notes

@ShanaLMoore ShanaLMoore added bug something isn't working M1 Milestone 1 labels Sep 11, 2024
laritakr added a commit that referenced this issue Sep 11, 2024
Refs #797

Custom collection show page did not work. Revert to use Hyku's show.
laritakr added a commit that referenced this issue Sep 11, 2024
# Story

Collection branding is not working. Several views were overriding Hyku
and had not been updated to work with Valkyrie. The overrides are no
longer needed and are being removed.

Refs #797

# Expected Behavior Before Changes

Branding banner and thumbnail did not work for collections.

# Expected Behavior After Changes

All collection branding options work.
Alt text is filled in when entered.
Logo links to url if entered.

# Screenshots / Video

<details>
<summary></summary>

![Screenshot 2024-09-11 at 2 17
56 PM](https://github.com/user-attachments/assets/c500a035-6abd-4be4-ab79-63fa0b77c5da)

### Alt Text
![Screenshot 2024-09-11 at 2 18
24 PM](https://github.com/user-attachments/assets/2b665e64-5df2-4339-84a7-884265baad75)

![Screenshot 2024-09-11 at 2 18
46 PM](https://github.com/user-attachments/assets/02fd0590-a7da-4f24-a423-1d6d891d4975)

![Screenshot 2024-09-11 at 2 19
07 PM](https://github.com/user-attachments/assets/1e243aee-95eb-4c42-b9da-7e1090950e1c)

</details>

# Notes
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Sep 17, 2024

QA RESULTS: ✅ PASS

tested on STAGING

I uploaded a banner, logo, and thumbnail. I filled in alt text and link url when available.

Image

public view of collection

Image

  • the alt text and link urls are present/working as well

Image

@KatharineV
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working M1 Milestone 1
Projects
Status: Deploy to Production
Development

No branches or pull requests

3 participants