Remove collection show #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs #797 Custom collection show page did not work. Revert to use Hyku's show.
Obsolete overriding of Hyku's version
sjproctor
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Collection branding is not working. Several views were overriding Hyku and had not been updated to work with Valkyrie. The overrides are no longer needed and are being removed.
Refs #797
Expected Behavior Before Changes
Branding banner and thumbnail did not work for collections.
Expected Behavior After Changes
All collection branding options work.
Alt text is filled in when entered.
Logo links to url if entered.
Screenshots / Video
Alt Text
Notes