Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix for human_readable_label_name not defined #11

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Sep 28, 2023

When running a job that attached a file set we received errors because the private methods were missing from this project. They exist in an adventist override: https://github.com/scientist-softserv/adventist-dl/blob/main/app/indexers/hyrax/file_set_indexer.rb

When running a job that attached a file set we'd receive errors because the private methods haven't been pulled over into this project.
Copy link
Contributor

@laritakr laritakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like @orangewolf to take a look at this... it seems strange to me that private methods would need to be overridden when they don't change.

But if this IS the case, we definitely should be documenting the reason we included them.

@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Sep 28, 2023

@laritakr I'm not sure what you mean, I copied it from here: https://github.com/scientist-softserv/adventist-dl/blob/main/app/indexers/hyrax/file_set_indexer.rb

We created a decorator but didn't pull over all of the methods. When we run jobs currently, it fails because they're missing but the indexer calls on them.

@laritakr
Copy link
Contributor

@laritakr I'm not sure what you mean, I copied it from here: https://github.com/scientist-softserv/adventist-dl/blob/main/app/indexers/hyrax/file_set_indexer.rb

@ShanaLMoore
Ah ok, I missed that you were just pulling in existing code... I thought you were overriding something new and was very confused.

Can you add back the comment explaining what is being overridden?

@ShanaLMoore ShanaLMoore merged commit 393a314 into main Sep 28, 2023
3 of 4 checks passed
@ShanaLMoore ShanaLMoore deleted the pull-over-fileset-private-methods branch October 2, 2023 16:35
ShanaLMoore pushed a commit that referenced this pull request Jul 17, 2024
🎁 Add SimpleSchemaLoaderDecorator for work types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants