Do not split if pdfjs flipper on #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a way to turn off pdf splitting for a tenant.
Doing it in the splitter meant the job errored instead of just not splitting.
|
Tests are running here: https://github.com/scientist-softserv/adventist_knapsack/actions/runs/10635044034 |
kirkkwang
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Refs
Expected Behavior Before Changes
If the original file has a .pdf suffix, IiifPrint split will be attempted.
Expected Behavior After Changes
PDFjs/UV feature flipper
use_iiif_printwill bypass splitting when set to PDFjs.Screenshots / Video
Notes
Adding the flag to the splitter allowed the jobs to run and fail because no images were split. Instead the flag was moved to the beginning of the job itself, allowing the process to stop before submitting any further jobs.