Sync views with Hyrax/Hyku #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Story Update the staging cluster issuer in the helm deploy values file to `wildcard-issuer` This is live on production and persists the changes for the next deployment to staging. - #699 # Expected Behavior Before Changes cert manager is not renewing certificates for staging automatically # Expected Behavior After Changes cert manager is now renews certificates for staging automatically # Screenshots / Video <details> <summary>Cert renewed</summary> <img width="1496" alt="Screenshot 2024-07-19 at 09 27 05" src="https://github.com/user-attachments/assets/6f4ab022-a464-4f5d-af79-51cbb197929e"> </details>
As much as possible, this attempts to remove views and use Hyku/Hyrax views instead. Documentation is also added regarding the purpose of views which override Hyku or Hyrax.
…knapsack into sync-views
ShanaLMoore
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
To make future upgrades easier, this work attempts to remove unnecessary views, and document the purpose of the overrides for views which are needed.
Refs #798
Expected Behavior Before Changes
Expected Behavior After Changes
No behavior changes are expected.
Screenshots / Video
Notes