I847 fix date range facet #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the date range facet didn't work because sorted_date_* weren't being indexed. We are pulling that code over from the active fedora indexer so that valkyrie resources can have it too. This will require environments to be reindexed. Issue: - #847
ShanaLMoore
force-pushed
the
i847-fix-date-range-facet
branch
from
3856baa
to
551c93e
Compare
ShanaLMoore
force-pushed
the
i847-fix-date-range-facet
branch
from
551c93e
to
2153fe4
Compare
laritakr
reviewed
Oct 15, 2024
laritakr
approved these changes
Oct 15, 2024
addresses PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
This fixes the date range facet.⚠️ Reindex is required ⚠️
Refs
Expected Behavior Before Changes
Date Range facet did not return any results
Screenshots / Video
Notes
Data must have date_created, which is a use input field.