🎁 Create and set up MobiusWork (a valkyrie resource work) #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Generate a new Valkyrie Resource to use for Mobius.
laritakr
changed the title
laritakr
changed the title
- merge in main to bring in knapsack updates - update submodule to bring in hyku updates
Brings in necessary changes for schema loader.
Controller needs to include Hyku behavior Add more details to mobius work
This commit will fix a bug where the controller template was not being found as well as the model spec. The path was corrected to match the path found in Hyrax. Lastly, the generator now includes adding Hyku specific includes to the controller and model files that were generated.
This commit will add logic for mobius tenants to get the mobius specific work type and non-mobius tenants to get all work types minus the mobius work type.
Update `HykuKnapsack::WorkResourceGenerator`
jeremyf
approved these changes
Mar 19, 2024
Prior, Mobius collections were coming in as CsvEntry objects and not CsvCollectionEntry objects. This was fixed with the CsvParserDecorator by adding the model key and setting it to `'CollectionResource'`. There was a change in Bulkrax to account for this as well so we updated the submodule's Bulkrax SHA as well. Lastly, there was some string manipulation added to HasLocalProcessing as well. Ref: - #169
This commit will add MOBIUS specific logic. MOBIUS works come in as a tar.gz file with multiple CSVs and multiple folders of files. The added logic will combine the CSVs into one and move the files into a single single directory called `files`. This will allow Bulkrax to easily process the files. The combined CSVs will have a new `file` and `model` column to allow Bulkrax to know which file to attach to which work. Ref: - #170
kirkkwang
force-pushed
the
valkyrie-update
branch
from
d3d2fd0
to
c8c2072
Compare
This commit will prevent the thumbnail images from being ingested. The clients indicated that the Hyrax handling of thumbnails should suffice and do not need any custom handling of thumbnails. Ref: - #171
kirkkwang
force-pushed
the
valkyrie-update
branch
from
15e5f3b
to
3d1abc8
Compare
We're noticing that some of the MOBIUS PDFs were throwing errors when trying to do the Hyrax text extraction. Putting in a rescue for the time being to prevent the error to stop thumbnail the derivatives process. Ultimately when we get IIIF Print Valkyrie ready, the OCR would be done there instead.
This commit will add more includes to the MobiusWork form and indexer following the pattern of the GenericWorksResource.
…rv/hykuup_knapsack into valkyrie-update
This commit will add the logic to check that the CSV's filename ends with `C&C.csv` as a fallback for marking rows as collections. It was noted that there are data decrpencies in the CSVs where not all collections were marked as such. But the client confirmed that all the entries in the CSVs that end with C&C.csv are collections.
Refs #182
Prior to this commit, we might have a situation where the initialize_app container's gems are not what is indicated by the Gemfile.lock. Which creates problems when we run the `bundle exec rails db:create`; namely the error will mention that we don't have the gem installed. We can circumvent this via different docker compose files; however, it seems reasonable to demand that we `bundle` before we execute `bundle exec`; especially when we consider the fact that we're not always running migrations.
This commit will remove a spec that is no longer relevant and also add a persisted volume to the staging and production deployment templates.
Sets up sentry for error reporting in staging and prod environments. Issue: - #193
🎁 [i193] - set up sentry
This commit will clean up the CsvParserDecorator spec by removing mentions of account since this was an older implementation.
kirkkwang
force-pushed
the
valkyrie-update
branch
from
796abed
to
7e0e3ab
Compare
In CI we're seeing this error: ``` LoadError: cannot load such file -- /app/samvera/spec/hyrax-webapp/config/environment ``` The rails_helper is in the /app/samvera/spec directory and then it's trying to load the environment from the hyrax-webapp directory within its current directory. Also, adding a `require 'rails_helper'` to the top of the `csv_parser_decorator_spec` to ensure that the Rails environment is loaded because we were seeing that the `Bulkrax` constant was not defined. Lastly, put a conditional around the FactoryBot configuration in the `rails_helper` because I'm not seeing HykuAddons as a gem in this particular project.
kirkkwang
force-pushed
the
valkyrie-update
branch
from
7e0e3ab
to
4392edd
Compare
kirkkwang
reviewed
Apr 2, 2024
This commit will update the submodule with its latest release now on main and any references to i35 to main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Refs:
Updates submodule to use i35-valkyrize-hyku
Creates MobiusWork
It was decided to omit the following pieces for now due to time constraints, as available work types can be maintained via the admin dashboard.
Limits use of MobiusWork to only Mobius tenantsRestricts use of other work types to only non-Mobius tenantsExpected Behavior Before Changes
Expected Behavior After Changes
Screenshots / Video
Notes