🧹 add delete to checkbox label #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[i40] Delete was missing from the description of the checkbox label, causing it to fail the accessibility audit. - Issue: #40
alishaevn
approved these changes
Jul 24, 2023
We will run translations in a separate ticket. ref: #487
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
[i40] Delete was missing from the description of the checkbox label, causing it to fail the accessibility audit.
Expected Behavior Before Changes
Expected Behavior After Changes
COLLECTIONS
MY COLLECTIONS
WORKS
Notes
we are trying to hit a deadline for UTK. I created a separate ticket to contribute this back to hyku and to run translations towards the end of the milestone.