Skip to content

Fix argmin example title in readme file + fix travis build for node version 0.12 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rodmcnew wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix argmin example title in readme file + fix travis build for node version 0.12 #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2ea1c11
Fix description of example codeblock in readme
rodmcnew May 28, 2017
bb67150
see if "sudo: false" fixes travis build
rodmcnew May 28, 2017
687fbb3
troubleshoot test
rodmcnew May 28, 2017
8c942b7
troubleshoot travis build for node version 0.12
rodmcnew May 28, 2017
0f89d5d
revert changes to troubleshoot travis build
rodmcnew May 28, 2017
4dfe599
troubleshoot travis build for node version 0.12
rodmcnew May 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,3 @@ node_js:
- 0.12
- 4
- 5

before_install:
- npm install npm@latest -g
Copy link
Author

@rodmcnew rodmcnew May 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The travis build for node v0.12 was failing until I removed this. There was an error message saying that the latest version of npm doesn't support node v0.12

2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ if(any(array)) {
}
```

## Compute the index of the maximum element of an array:
## Compute the index of the minimum element of an array:
```javascript
var argmin = cwise({
args: ["index", "array"],
Expand Down