add comment to not forget

scikit-hep · Feb 13, 2025 · ba4c666 · ba4c666
1 parent fed02cb
commit ba4c666
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/awkward/_nplikes/cupy.py b/src/awkward/_nplikes/cupy.py
@@ -170,6 +170,7 @@ def is_own_array_type(cls, type_: type) -> bool:
         Return `True` if the given object is a cupy buffer, otherwise `False`.
 
         """
+        # TODO: Implement this fore virtual arrays
         module, _, suffix = type_.__module__.partition(".")
         return module == "cupy"
 

diff --git a/src/awkward/_nplikes/numpy.py b/src/awkward/_nplikes/numpy.py
@@ -46,6 +46,7 @@ def is_own_array_type(cls, type_: type) -> bool:
         Return `True` if the given object is a numpy buffer, otherwise `False`.
 
         """
+        # TODO: Implement this for virtual arrays
         return issubclass(type_, numpy.ndarray)
 
     def is_c_contiguous(self, x: NDArray | PlaceholderArray) -> bool: