-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: failing tests after #2877 #2886
Conversation
Codecov Report
Additional details and impacted files
|
@ManasviGoyal - could you, please, run the linter and fix the warnings? Thanks! |
I think we need to update the |
why is suddenly failing? what was changed? |
@ManasviGoyal is right that we should bump the PyLint Python version. I'd missed that when we last updated our Python bounds. I'm not sure why PyLint suddenly started noticing, though. I think we can safely assume that it's a strictness update on their part being pulled in via CI. No need to dig into it, though - we clearly should correct this on our side. |
46cb7c9
to
a47a52c
Compare
@ManasviGoyal don't worry about pylint here - I'll fix it in a new PR. |
Thanks! |
@ianna I think this can be squash and merged now, right? |
Just noticed that a few changes in #2877 are making the cuda tests fail. So I have fixed them.