Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TypeError fix for can_cast #3255

Merged

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Sep 25, 2024

fixes issue #3205

@ianna ianna linked an issue Sep 25, 2024 that may be closed by this pull request
@ianna ianna changed the title [fix] TypeError fix for can_cast fix: TypeError fix for can_cast Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.02%. Comparing base (b749e49) to head (8cc6f93).
Report is 163 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
src/awkward/_broadcasting.py 92.50% <100.00%> (-2.86%) ⬇️
src/awkward/_nplikes/array_module.py 89.56% <100.00%> (+3.18%) ⬆️

... and 104 files with indirect coverage changes

Copy link
Collaborator Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpivarski - please, check when you have time. This PR ensures that the scalars passed to cupy functions are the zero dimensional cupy.ndarrays. I've tested the PR with cupy 13.2 (where the type error occurred) and with cupy 13.3 (where can_cast accepts the Python types).

@jpivarski
Copy link
Member

I've verified that all tests work on my GPU.

@ianna ianna merged commit 704fb45 into scikit-hep:main Sep 26, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CUDA: tests fail with TypeError: can_cast()
2 participants