Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure 'at' is a cupy zero dim array #3271

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix: make sure 'at' is a cupy zero dim array #3271

merged 1 commit into from
Oct 9, 2024

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Oct 7, 2024 •
edited
Loading

fixes #3280

@ianna ianna changed the title [fix] make sure 'at' is a cupy zero dim array fix: make sure 'at' is a cupy zero dim array Oct 7, 2024
@ianna
Copy link
Collaborator Author

ianna commented Oct 7, 2024

@martindurant - I hope this PR fixes your issue with indexing.

@martindurant
Copy link
Contributor

Wow, thanks for looking into it!

@codecov Codecov
Copy link

codecov bot commented Oct 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (b749e49) to head (32a507e).
Report is 175 commits behind head on main.

Additional details and impacted files

see 108 files with indirect coverage changes

@ianna
Copy link
Collaborator Author

ianna commented Oct 8, 2024

fixes #3280

@ianna ianna requested a review from jpivarski October 8, 2024 19:56
ianna
ianna commented Oct 8, 2024
View reviewed changes
Copy link
Collaborator Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpivarski - the tests pass integers. The Python wrapping of the kernels converts the 'at' parameter to a cupy array.

@ianna ianna self-assigned this Oct 8, 2024
jpivarski
jpivarski approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this passes all tests on my GPU and it's ready to be merged. Thank you!

@ianna ianna merged commit 0a92539 into scikit-hep:main Oct 9, 2024
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees

@ianna ianna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pytest tests-cuda-kernels is currently failing on my GPU
3 participants
@ianna @martindurant @jpivarski