Skip to content

Commit

Permalink
ci: Remove upgrade of wheel (#2542)
Browse files Browse the repository at this point in the history
* Remove upgrading of wheel from CI workflows.
   - For dependencies that don't provide a wheel, and don't have build-system
     metadata in pyproject.toml, modern setuptools has integrated wheel and so
     installation is unnecessary.
* Remove 'uv pip install --system --upgrade pip' as 'uv pip' is a different
  program.
  • Loading branch information
matthewfeickert committed Sep 19, 2024
1 parent aab3468 commit 609af88
Show file tree
Hide file tree
Showing 9 changed files with 2 additions and 15 deletions.
1 change: 0 additions & 1 deletion .github/workflows/bump-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@ jobs:
- name: Install Python dependencies
run: |
python -m pip install uv
uv pip install --system --upgrade pip wheel
uv pip install --system tbump
python -m pip list
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ci-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ jobs:
- name: Install dependencies
run: |
python -m pip install uv
uv pip install --system --upgrade pip wheel
uv pip install --system --upgrade '.[all,test]'
- name: List installed Python packages
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,13 @@ jobs:
if: matrix.python-version != '3.8'
run: |
python -m pip install uv
uv pip install --system --upgrade pip wheel
uv pip install --system --upgrade ".[all,test]"
# c.f. https://github.com/astral-sh/uv/issues/2062
- name: Install dependencies (Python 3.8)
if: matrix.python-version == '3.8'
run: |
python -m pip install --upgrade pip wheel
python -m pip install --upgrade pip
python -m pip install --upgrade ".[all,test]"
- name: List installed Python packages
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/dependencies-head.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ jobs:
- name: Install dependencies
run: |
python -m pip install uv
uv pip install --system --upgrade pip wheel
uv pip --no-cache --quiet install --system --upgrade --pre ".[all,test]"
python -m pip list
Expand Down Expand Up @@ -64,7 +63,6 @@ jobs:
- name: Install dependencies
run: |
python -m pip install uv
uv pip install --system --upgrade pip wheel
uv pip --no-cache --quiet install --system --upgrade ".[all,test]"
uv pip uninstall --system scipy
# uv wants to upgrade dependencies (numpy) to a dev release too, so don't --upgrade
Expand Down Expand Up @@ -92,7 +90,6 @@ jobs:
- name: Install dependencies
run: |
python -m pip install uv
uv pip install --system --upgrade pip wheel
uv pip --no-cache --quiet install --system --upgrade ".[all,test]"
uv pip uninstall --system iminuit
uv pip install --system --upgrade cython
Expand All @@ -119,7 +116,6 @@ jobs:
- name: Install dependencies
run: |
python -m pip install uv
uv pip install --system --upgrade pip wheel
uv pip --no-cache --quiet install --system --upgrade ".[all,test]"
uv pip uninstall --system uproot
uv pip install --system --upgrade git+https://github.com/scikit-hep/uproot5.git
Expand Down Expand Up @@ -147,7 +143,6 @@ jobs:
- name: Install dependencies
run: |
python -m pip install uv
uv pip install --system --upgrade pip wheel
uv pip --no-cache --quiet install --system --upgrade ".[all,test]"
uv pip uninstall --system matplotlib
# Need to use --extra-index-url as all dependencies aren't on scientific-python-nightly-wheels package index.
Expand Down Expand Up @@ -184,7 +179,6 @@ jobs:
- name: Install dependencies
run: |
python -m pip install uv
uv pip install --system --upgrade pip wheel
uv pip --no-cache --quiet install --system --upgrade ".[all,test]"
uv pip uninstall --system pytest
uv pip install --system --upgrade git+https://github.com/pytest-dev/pytest.git
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ jobs:
- name: Install Python dependencies
run: |
python -m pip install uv
uv pip install --system --upgrade pip wheel
uv pip --quiet install --system --upgrade ".[docs,test]"
uv pip install --system yq
python -m pip list
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lower-bound-requirements.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Install dependencies and force lowest bound
run: |
python -m pip install uv
uv pip install --system --upgrade pip 'setuptools<70.0.0' wheel
uv pip install --system --upgrade 'setuptools<70.0.0'
uv pip --no-cache install --system --constraint tests/constraints.txt ".[all,test]"
- name: List installed Python packages
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/notebooks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ jobs:
- name: Install dependencies
run: |
python -m pip install uv
uv pip install --system --upgrade pip wheel
# FIXME: c.f. https://github.com/scikit-hep/pyhf/issues/2104
uv pip install --system --upgrade ".[all,test]" 'jupyter-client<8.0.0'
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/release_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ jobs:
- name: Install from PyPI
run: |
python -m pip install uv
uv pip install --system --upgrade pip wheel
uv pip install --system --pre 'pyhf[backends,xmlio]'
uv pip install --system pytest
python -m pip list
Expand Down
1 change: 0 additions & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ RUN apt-get -qq -y update && \
. /usr/local/venv/bin/activate && \
cd /code && \
python -m pip --no-cache-dir install --upgrade uv && \
uv pip install --no-cache --upgrade pip wheel && \
uv pip install --no-cache '.[xmlio,contrib]' && \
uv pip list

Expand Down

0 comments on commit 609af88

Please sign in to comment.