Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add filterwarnings ignore for jsonschema.RefResolver DeprecationWarning #2246

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jul 6, 2023

Description

Add an ignore to filterwarnings to avoid jsonschema.RefResolver DeprecationWarning

DeprecationWarning: jsonschema.RefResolver is deprecated as of v4.18.0, in favor of the https://github.com/python-jsonschema/referencing library, which provides more compliant referencing behavior as well as more flexible APIs for customization. A future release will remove RefResolver. Please file a feature request (on referencing) if you are missing an API for the kind of customization you need.

This filterwarning should be removed once pyhf updates to referencing.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add an ignore to filterwarnings to avoid jsonschema.RefResolver DeprecationWarning

> DeprecationWarning: jsonschema.RefResolver is deprecated as of v4.18.0, in favor
> of the https://github.com/python-jsonschema/referencing library, which provides
> more compliant referencing behavior as well as more flexible APIs for customization.
> A future release will remove RefResolver. Please file a feature request
> (on referencing) if you are missing an API for the kind of customization you need.

  This filterwarning should be removed once pyhf updates to referencing.
  - c.f. https://github.com/scikit-hep/pyhf/issues/2139

…Warning

* Add an ignore to filterwarnings to avoid jsonschema.RefResolver DeprecationWarning

> DeprecationWarning: jsonschema.RefResolver is deprecated as of v4.18.0, in favor
> of the https://github.com/python-jsonschema/referencing library, which provides
> more compliant referencing behavior as well as more flexible APIs for customization.
> A future release will remove RefResolver. Please file a feature request
> (on referencing) if you are missing an API for the kind of customization you need.

  This filterwarning should be removed once pyhf updates to python-jsonschema/referencing.
  - c.f. https://github.com/scikit-hep/pyhf/issues/ 2139
@matthewfeickert matthewfeickert added the fix A bug fix label Jul 6, 2023
@matthewfeickert matthewfeickert self-assigned this Jul 6, 2023
@matthewfeickert
Copy link
Member Author

@kratsg This currently just pushed Issue #2139 further off, but I hope that we can get that dealt with soon enough that this won't be an actual problem.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a28d1a3) 98.30% compared to head (9ad6479) 98.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2246   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4534     4534           
  Branches      802      802           
=======================================
  Hits         4457     4457           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.09% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.11 96.31% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit 576a855 into main Jul 6, 2023
20 checks passed
@matthewfeickert matthewfeickert deleted the fix/jsonschema-deprecation-warning branch July 6, 2023 22:28
@matthewfeickert matthewfeickert added the need-to-backport tmp label until can be backported to patch release branch label Jul 6, 2023
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant