Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Ignore Belle2 Indico URL during Sphinx linkcheck #2272

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Aug 10, 2023

Description

Ignore URLs for https://indico.belle2.org/event/8470 from Sphinx linkcheck tests as the URL https://indico.belle2.org/event/8470/contributions/55871/ is frequently generating 403 Client Error.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Ignore URLs for https://indico.belle2.org/event/8470 from Sphinx
  linkcheck tests as the URL
  https://indico.belle2.org/event/8470/contributions/55871/ is frequently
  generating 403 Client Error.

* Ignore URLs for https://indico.belle2.org/event/8470 from Sphinx
  linkcheck tests as the URL
  https://indico.belle2.org/event/8470/contributions/55871/ is frequently
  generating 403 Client Error.
@matthewfeickert matthewfeickert added docs Documentation related tests pytest need-to-backport tmp label until can be backported to patch release branch labels Aug 10, 2023
@matthewfeickert matthewfeickert self-assigned this Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (998ba7c) 98.30% compared to head (9c82787) 98.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2272   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4534     4534           
  Branches      802      802           
=======================================
  Hits         4457     4457           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.09% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.11 96.31% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit 2204e99 into main Aug 10, 2023
19 checks passed
@matthewfeickert matthewfeickert deleted the docs/avoid-linkcheck-error branch August 10, 2023 06:58
matthewfeickert added a commit that referenced this pull request Aug 15, 2023
* Ignore URLs for CERN's Twiki instance https://twiki.cern.ch/ from
  Sphinx linkcheck tests as CERN seems to have problems regularly
  maintaining their SSL certs which can lead to SSL errors.

  ```
  Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED]
  certificate verify failed: unable to get local issuer certificate (_ssl.c:1002)'))
  ```
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Aug 16, 2023
matthewfeickert added a commit that referenced this pull request Aug 16, 2023
* Backport components of:
   - PR #2252
   - PR #2255
   - PR #2267
   - PR #2271
   - PR #2272
   - PR #2276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related tests pytest
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant