Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Ignore CERN Twiki URLs during Sphinx linkcheck #2276

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Aug 15, 2023

Description

Ignore URLs for CERN's Twiki instance https://twiki.cern.ch/ from Sphinx linkcheck tests as CERN seems to have problems regularly maintaining their SSL certs which can lead to SSL errors.

Example:

Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1002)'))

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Ignore URLs for CERN's Twiki instance https://twiki.cern.ch/ from
  Sphinx linkcheck tests as CERN seems to have problems regularly
  maintaining their SSL certs which can lead to SSL errors.

  Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED]
  certificate verify failed: unable to get local issuer certificate (_ssl.c:1002)'))

* Ignore URLs for CERN's Twiki instance https://twiki.cern.ch/ from
  Sphinx linkcheck tests as CERN seems to have problems regularly
  maintaining their SSL certs which can lead to SSL errors.

  ```
  Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED]
  certificate verify failed: unable to get local issuer certificate (_ssl.c:1002)'))
  ```
@matthewfeickert matthewfeickert added docs Documentation related tests pytest need-to-backport tmp label until can be backported to patch release branch labels Aug 15, 2023
@matthewfeickert matthewfeickert self-assigned this Aug 15, 2023
@matthewfeickert matthewfeickert added the fix A bug fix label Aug 15, 2023
@matthewfeickert
Copy link
Member Author

As @PerilousApricot pointed out, seems like this time was due to an error in an attempt to update the certs

Image from iOS (1)

@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself (as I'm the person who is responsible for fixing linkcheck as I added this test). As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert changed the title test: Ignore CERN Twiki URLs during Sphinx linkcheck (#2272) test: Ignore CERN Twiki URLs during Sphinx linkcheck Aug 15, 2023
@matthewfeickert matthewfeickert merged commit 47f2576 into main Aug 15, 2023
18 checks passed
@matthewfeickert matthewfeickert deleted the test/ignore-twiki-links branch August 15, 2023 05:30
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Aug 16, 2023
matthewfeickert added a commit that referenced this pull request Aug 16, 2023
* Backport components of:
   - PR #2252
   - PR #2255
   - PR #2267
   - PR #2271
   - PR #2272
   - PR #2276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related fix A bug fix tests pytest
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant