Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Disallow TensorFlow v2.14.0 #2342

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Sep 26, 2023

Description

tensorflow v2.14.0 breaks tensorflow-probability at import time. Until this is fixed, tensorflow v2.14.0 can't be used.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* tensorflow v2.14.0 breaks tensorflow-probability at import time.
  Until this is fixed, tensorflow v2.14.0 can't be used.
   - c.f. https://github.com/tensorflow/probability/issues/1752

* tensorflow v2.14.0 breaks tensorflow-probability at import time.
  Until this is fixed, tensorflow v2.14.0 can't be used.
   - c.f. https://github.com/tensorflow/probability/issues/ 1752
@matthewfeickert matthewfeickert added fix A bug fix build Changes that affect the build system or external dependencies need-to-backport tmp label until can be backported to patch release branch labels Sep 26, 2023
@matthewfeickert matthewfeickert self-assigned this Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5f85222) 98.28% compared to head (7723480) 98.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2342   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          69       69           
  Lines        4538     4538           
  Branches      803      803           
=======================================
  Hits         4460     4460           
  Misses         45       45           
  Partials       33       33           
Flag Coverage Δ
contrib 97.86% <ø> (ø)
doctest 60.99% <ø> (ø)
unittests-3.10 96.29% <ø> (ø)
unittests-3.11 96.29% <ø> (ø)
unittests-3.8 96.31% <ø> (ø)
unittests-3.9 96.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit f280cb2 into main Sep 27, 2023
19 checks passed
@matthewfeickert matthewfeickert deleted the fix/restrict-tensorflow branch September 27, 2023 00:04
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Oct 3, 2023
matthewfeickert added a commit that referenced this pull request Oct 3, 2023
* With the release of tensorflow-probability v0.22.0, tensorflow v2.14.0
  can be used and is required for tensorflow-probability v0.22.0+.
   - c.f. https://github.com/tensorflow/probability/releases/tag/v0.22.0
* Reverts PR #2342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies fix A bug fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant