Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add award number for second phase of IRIS-HEP #2354

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Oct 18, 2023

Description

Adding the award number for the second phase of IRIS-HEP to the readme. I only saw the award number from the first phase mentioned in one other place, the JOSS acknowledgements, but those were prior work so I don't think it makes sense to update there.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add badge and funding acknowledgement for NSF cooperative agreement
  PHY-2323298 award for IRIS-HEP v2.
   - c.f. https://www.nsf.gov/awardsearch/showAward?AWD_ID=2323298

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2eb13e8) 98.28% compared to head (565d7e3) 98.28%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2354   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          69       69           
  Lines        4538     4538           
  Branches      803      803           
=======================================
  Hits         4460     4460           
  Misses         45       45           
  Partials       33       33           
Flag Coverage Δ
contrib 97.86% <ø> (ø)
doctest 60.70% <ø> (ø)
unittests-3.10 96.29% <ø> (ø)
unittests-3.11 96.29% <ø> (ø)
unittests-3.8 96.31% <ø> (ø)
unittests-3.9 96.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert added docs Documentation related need-to-backport tmp label until can be backported to patch release branch labels Oct 23, 2023
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexander-held! This had been on my TODO list.

@matthewfeickert matthewfeickert merged commit 5093668 into main Oct 23, 2023
21 checks passed
@matthewfeickert matthewfeickert deleted the docs/iris-hep-v2-award-number branch October 23, 2023 21:57
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Oct 25, 2023
matthewfeickert added a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants