Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: Personal applicataion of custom modifiers #2398

Draft
wants to merge 1 commit into
base: feat/addCustomModifierPython
Choose a base branch
from

Conversation

lorenzennio
Copy link
Contributor

Description

This is my personal use of a custom modifier. It includes some additional features:

  • usage of custom function
  • setting of custom parameter type
  • output of custom function does not have to match total number of bins (rather it places in the mask)

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR

@matthewfeickert matthewfeickert marked this pull request as draft December 8, 2023 16:27
@matthewfeickert
Copy link
Member

@lorenzennio can you rebase this to drop everything except for the relevant commit (the "personal use case of custom modifier" one) so that branch diff is more useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants