Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove Mypy 'show_error_codes' as now default #2414

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jan 4, 2024

Description

sp-repo-review MY102: Mypy show_error_codes deprecated: Must not have show_error_codes. Use hide_error_codes instead (since Mypy v0.990).

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* sp-repo-review MY102: Mypy show_error_codes deprecated
  Must not have show_error_codes. Use hide_error_codes instead (since Mypy v0.990).

* sp-repo-review MY102: Mypy show_error_codes deprecated
  Must not have show_error_codes. Use hide_error_codes instead (since Mypy v0.990).
@matthewfeickert matthewfeickert added chore Other changes that don't modify src or test files type checking Related to types and type checking need-to-backport tmp label until can be backported to patch release branch labels Jan 4, 2024
@matthewfeickert matthewfeickert self-assigned this Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4fdd6d6) 98.28% compared to head (3039a37) 98.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2414   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          69       69           
  Lines        4539     4539           
  Branches      803      803           
=======================================
  Hits         4461     4461           
  Misses         45       45           
  Partials       33       33           
Flag Coverage Δ
contrib 97.86% <ø> (ø)
doctest 60.71% <ø> (ø)
unittests-3.10 96.29% <ø> (ø)
unittests-3.11 96.29% <ø> (ø)
unittests-3.8 96.32% <ø> (ø)
unittests-3.9 96.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit 03b7286 into main Jan 4, 2024
21 checks passed
@matthewfeickert matthewfeickert deleted the chore/remove-mypy-show-error-codes branch January 4, 2024 22:39
matthewfeickert added a commit that referenced this pull request Jan 5, 2024
* sp-repo-review MY102: Mypy show_error_codes deprecated
  Must not have show_error_codes. Use hide_error_codes instead (since Mypy v0.990).
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Jan 5, 2024
matthewfeickert added a commit that referenced this pull request Jan 5, 2024
* Backport:
   - PR #2378
   - PR #2380
   - PR #2381
   - PR #2382
   - PR #2383
   - PR #2386
   - PR #2412
   - PR #2414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files type checking Related to types and type checking
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant