Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update services and docs to Python 3.12 as default #2461

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 20, 2024

Description

  • Update to using Python 3.12 in linting and validation tools.
  • Update Binder runtime Python to Python 3.12.
  • Update Dockerfile base image to python:3.12-slim-bullseye.
  • Update the docs to advocate using Python 3.12 for development.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update to using Python 3.12 in linting and validation tools.
* Update Binder runtime Python to Python 3.12.
* Update Dockerfile base image to python:3.12-slim-bullseye.
* Update the docs to advocate using Python 3.12 for development.

@matthewfeickert matthewfeickert added docs Documentation related CI CI systems, GitHub Actions chore Other changes that don't modify src or test files Docker Involving Docker images or builds need-to-backport tmp label until can be backported to patch release branch labels Mar 20, 2024
@matthewfeickert matthewfeickert self-assigned this Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (dd4a243) to head (2886bea).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2461   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          69       69           
  Lines        4541     4541           
  Branches      804      804           
=======================================
  Hits         4460     4460           
  Misses         48       48           
  Partials       33       33           
Flag Coverage Δ
contrib 97.79% <ø> (ø)
doctest 98.08% <ø> (ø)
unittests-3.10 96.23% <ø> (ø)
unittests-3.11 96.23% <ø> (ø)
unittests-3.12 96.23% <ø> (ø)
unittests-3.8 96.25% <ø> (ø)
unittests-3.9 96.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert changed the title chore: Update to Python 3.12 for all repo actions and docs chore: Update services and docs to Python 3.12 as default Mar 20, 2024
@matthewfeickert matthewfeickert added the Binder Contributing to having Binder build and Binder images run smoothly label Mar 20, 2024
@matthewfeickert matthewfeickert merged commit db67210 into main Mar 20, 2024
24 checks passed
@matthewfeickert matthewfeickert deleted the chore/update-everything-to-py-3-12 branch March 20, 2024 18:06
matthewfeickert added a commit that referenced this pull request May 30, 2024
* Backport:
   - PR #2485
   - PR #2486
   - parts of PR #2461

---------

Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
@matthewfeickert
Copy link
Member Author

@meeseeksdev backport to release/v0.7.x

Copy link

lumberbot-app bot commented May 30, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout release/v0.7.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 db67210ec76007db1a5b6818644fe721662d5249
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #2461: chore: Update services and docs to Python 3.12 as default'
  1. Push to a named branch:
git push YOURFORK release/v0.7.x:auto-backport-of-pr-2461-on-release/v0.7.x
  1. Create a PR against branch release/v0.7.x, I would have named this PR:

"Backport PR #2461 on branch release/v0.7.x (chore: Update services and docs to Python 3.12 as default)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Binder Contributing to having Binder build and Binder images run smoothly chore Other changes that don't modify src or test files CI CI systems, GitHub Actions Docker Involving Docker images or builds docs Documentation related
Projects
Status: No status
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant