Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use uv during Dockerfile build #2485

Merged
merged 3 commits into from
May 25, 2024
Merged

chore: Use uv during Dockerfile build #2485

merged 3 commits into from
May 25, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented May 25, 2024

Description

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Speed up the Dockerfile build by using uv to install all Python
  dependencies.
* Have hadolint ignore SC1091 in Dockerfile.
   - c.f. https://www.shellcheck.net/wiki/SC1091

@matthewfeickert matthewfeickert added chore Other changes that don't modify src or test files Docker Involving Docker images or builds need-to-backport tmp label until can be backported to patch release branch labels May 25, 2024
@matthewfeickert matthewfeickert self-assigned this May 25, 2024
Copy link

codecov bot commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (42cd129) to head (5f472f4).
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2485   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          69       69           
  Lines        4543     4543           
  Branches      804      804           
=======================================
  Hits         4462     4462           
  Misses         48       48           
  Partials       33       33           
Flag Coverage Δ
contrib 97.79% <ø> (ø)
doctest 98.08% <ø> (ø)
unittests-3.10 96.23% <ø> (ø)
unittests-3.11 96.23% <ø> (ø)
unittests-3.12 96.23% <ø> (ø)
unittests-3.8 96.25% <ø> (ø)
unittests-3.9 96.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Speed up the Dockerfile build by using uv to install all Python
  dependencies.
@matthewfeickert matthewfeickert merged commit f4eb73f into main May 25, 2024
25 checks passed
@matthewfeickert matthewfeickert deleted the docker/use-uv branch May 25, 2024 21:18
@matthewfeickert
Copy link
Member Author

@meeseeksdev backport to release/v0.7.x

meeseeksmachine pushed a commit to meeseeksmachine/pyhf that referenced this pull request May 30, 2024
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label May 30, 2024
matthewfeickert added a commit that referenced this pull request May 30, 2024
* Backport:
   - PR #2485
   - PR #2486
   - parts of PR #2461

---------

Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files Docker Involving Docker images or builds
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant