Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Lower tolerance for iminuit v2.26.0+ on Apple silicon #2514

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jun 7, 2024

Description

Lower the tolerance for the tests/test_optim.py test_optim_uncerts test to reach agreement for iminuit v2.26.0+ on Apple silicon.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Lower the tolerance for the tests/test_optim.py test_optim_uncerts test
  to reach agreement for iminuit v2.26.0+ on Apple silicon.

* Lower the tolerance for the tests/test_optim.py test_optim_uncerts test to reach agreement
  for iminuit v2.26.0 on Apple silicon.
@matthewfeickert matthewfeickert added tests pytest fix A bug fix need-to-backport tmp label until can be backported to patch release branch labels Jun 7, 2024
@matthewfeickert matthewfeickert self-assigned this Jun 7, 2024
@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (faa4ccf) to head (5ba4410).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2514      +/-   ##
==========================================
+ Coverage   98.08%   98.21%   +0.13%     
==========================================
  Files          69       69              
  Lines        4543     4543              
  Branches      696      804     +108     
==========================================
+ Hits         4456     4462       +6     
+ Misses         51       48       -3     
+ Partials       36       33       -3     
Flag Coverage Δ
contrib 97.79% <ø> (ø)
doctest 98.08% <ø> (ø)
unittests-3.10 96.23% <ø> (?)
unittests-3.11 96.23% <ø> (?)
unittests-3.12 96.23% <ø> (ø)
unittests-3.8 96.25% <ø> (?)
unittests-3.9 96.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit dd95dee into main Jun 7, 2024
24 checks passed
@matthewfeickert matthewfeickert deleted the test/lower-tolerance-for-arm64 branch June 7, 2024 06:44
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Jun 7, 2024
@matthewfeickert
Copy link
Member Author

@meeseeksdev backport to release/v0.7.x

meeseeksmachine pushed a commit to meeseeksmachine/pyhf that referenced this pull request Jun 7, 2024
matthewfeickert added a commit that referenced this pull request Jun 7, 2024
…#2515)

* Backport PR #2514
* Lower the tolerance for the tests/test_optim.py test_optim_uncerts test
  to reach agreement for iminuit v2.26.0+ on Apple silicon.

Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix tests pytest
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant