Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use shutil.copytree over setuptools._distutils #2518

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jun 17, 2024

Description

As setuptools is not the build backend there should be no reliance on setuptools or distutils for use. This exchanges setuptools._distutils.dir_util.copy_tree for shutil.copytree with dirs_exist_ok=True as pyhf supports Python 3.8+.

Follows up on an idea brought forward in PR #1711.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* As setuptools is not the build backend there should be no reliance on
  setuptools or distutils for use. This exchanges
  setuptools._distutils.dir_util.copy_tree for shutil.copytree with
  dirs_exist_ok=True as pyhf supports Python 3.8+.

* As setuptools is not the build backend there should be no reliance on
  setuptools or distutils for use. This exchanges
  setuptools._distutils.dir_util.copy_tree for shutil.copytree as pyhf
  supports Python 3.8+.
@matthewfeickert matthewfeickert added tests pytest fix A bug fix labels Jun 17, 2024
@matthewfeickert matthewfeickert self-assigned this Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (e8789a2) to head (982171e).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2518   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          69       69           
  Lines        4543     4543           
  Branches      804      804           
=======================================
  Hits         4462     4462           
  Misses         48       48           
  Partials       33       33           
Flag Coverage Δ
contrib 97.79% <ø> (ø)
doctest 98.08% <ø> (ø)
unittests-3.10 96.23% <ø> (ø)
unittests-3.11 96.23% <ø> (ø)
unittests-3.12 96.23% <ø> (ø)
unittests-3.8 96.25% <ø> (ø)
unittests-3.9 96.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit a0caf31 into main Jun 17, 2024
24 checks passed
@matthewfeickert matthewfeickert deleted the test/remove-distutils branch June 17, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix tests pytest
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant