fix: Use shutil.copytree over setuptools._distutils #2518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As
setuptools
is not the build backend there should be no reliance onsetuptools
ordistutils
for use. This exchangessetuptools._distutils.dir_util.copy_tree
forshutil.copytree
withdirs_exist_ok=True
as pyhf supports Python 3.8+.Follows up on an idea brought forward in PR #1711.
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: