Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove occurrences of matrix.python-version.key || in ci.yml #517

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Yogendra0Sharma
Copy link
Contributor

@Yogendra0Sharma Yogendra0Sharma commented Oct 8, 2024

Description

Kindly take a look at CONTRIBUTING.md.

Please describe the purpose of this pull request. Reference and link to any relevant issues or pull requests.

Checklist

  • [#] Have you followed the guidelines in our Contributing document?
  • [#] Have you checked to ensure there aren't any other open Pull Requests for the required change?
  • [#] Does your submission pass pre-commit? ($ pre-commit run --all-files or $ nox -s lint)
  • [#] Does your submission pass tests? ($ pytest or $ nox -s tests)
  • [#] Does the documentation build with your changes? ($ cd docs; make clean; make html or $ nox -s docs)
  • [#] Does your submission pass the doctests? ($ pytest --doctest-plus src/vector/ or $ nox -s doctests)

Before Merging

@Saransh-cpp Saransh-cpp linked an issue Oct 8, 2024 that may be closed by this pull request
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up, @Yogendra0Sharma! :)

@Saransh-cpp Saransh-cpp merged commit 12f7b7d into scikit-hep:main Oct 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove occurrences of matrix.python-version.key || in ci.yml
2 participants