Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Install tractolearn from GitHub #3

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

jhlegarreta
Copy link
Contributor

Install tractolearn from GitHub

@jhlegarreta
Copy link
Contributor Author

@felixdumais have not tested.

@fdumais fdumais closed this Feb 6, 2023
@fdumais fdumais reopened this Feb 6, 2023
@jhlegarreta
Copy link
Contributor Author

@fdumais So removing the additions and working directory makes the trick?

@fdumais
Copy link
Contributor

fdumais commented Feb 7, 2023

Yes, can you just remove the workdir and all the add and replace with this:
RUN git clone https://github.com/scil-vital/tractolearn.git /tractolearn

@fdumais fdumais marked this pull request as ready for review February 7, 2023 00:42
Install `tractolearn` from GitHub
@jhlegarreta
Copy link
Contributor Author

Yes, can you just remove the workdir and all the add and replace with this:
RUN git clone https://github.com/scil-vital/tractolearn.git /tractolearn

Done. In the mid-term we will be willing to pin the version so that a stable/tagged/release version is used.

@jhlegarreta
Copy link
Contributor Author

Unrelated to this patch set:
https://github.com/scil-vital/dockerfile_tractolearn/blob/main/Dockerfile#L57

The directory change in there is redundant as there is another one changing to the same directory immediately before.

@fdumais fdumais merged commit eb03ebc into scil-vital:main Feb 7, 2023
@jhlegarreta jhlegarreta deleted the GetTractolearnFromGH branch February 7, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants