Skip to content

Commit

Permalink
Merge pull request #207 from EmmaRenauld/update_hot_dipy
Browse files Browse the repository at this point in the history
Update requirements for hot dipy
  • Loading branch information
EmmaRenauld committed Oct 7, 2023
2 parents ceab621 + 5159008 commit b7ac03a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 15 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/test_package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,10 @@ jobs:

- name: Install dependencies
run: |
# python -m pip install --upgrade --user pip
pip install pytest
pip install --upgrade pip
pip install pytest
pip install -r requirements_github.txt
pip install .
pip install -e .
- name: Tests
run: |
Expand Down
18 changes: 6 additions & 12 deletions requirements_github.txt
Original file line number Diff line number Diff line change
@@ -1,16 +1,10 @@

git+https://github.com/EmmaRenauld/scilpy.git@master#egg=scilpy
# Will install dipy through requirements.



# ---------------
# Note to developpers
# In case scilpy reverts to hot dipy one day:
# Previous hot dipy led to errors, and we prefered keeping official dipy:
# Could not manage to import hot dipy on github.
# We had to use Emmanuelle Renauld's branch of scilpy, with hot dipy skipped.
#
# -e git+https://github.com/scilus/hot_dipy@1.6.1rc1#egg=dipy
# --> issue with -e: pytest seems to redo ALL tests.
# --> issue without e: bug with Cython. Arnaud and Francois from scilpy
# couldn't help.

# Not installing dipy. Will be installed trough my scilpy.
git+https://github.com/EmmaRenauld/scilpy.git@BRANCH_OLD_DIPY#egg=scilpy
# Will install dipy through requirements.

0 comments on commit b7ac03a

Please sign in to comment.