Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectrpc: generate code with buf #4540

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Commits on Sep 14, 2024

  1. connectrpc: generate code with buf

    Generate the additional code required for connectrpc with the buf
    tool. Currently, there is no bazel ruleset available for buf. We work
    around this by invoking the buf binary directly and commiting the
    generated code in git. To deal with generation, we pin the
    `protoc-gen-connect-go` version in the go.mod file. A small scaffolding
    go binary is added to deal with setting up the environment correctly
    for the buf tool. While this could be a shell script, this is more
    readable and maintainable.
    
    This PR is broken out of the
    https://github.com/scionproto/scion/tree/connectrpc branch to make
    incremental review easier.
    
    TL;DR: Run `bazel run //tools/buf` to generate the connectrpc code.
    oncilla committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    9bee99a View commit details
    Browse the repository at this point in the history
  2. use protoc plugin

    oncilla committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    e3ba3f5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fa62993 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Configuration menu
    Copy the full SHA
    641bd7f View commit details
    Browse the repository at this point in the history