-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: proposal for nat address discovery #4560
Conversation
NAT address discovery
The build currently fails because the proposal is not in any TOC-tree. As I understand it, this is by design because, following Please let me know if the build problem should be fixed before proceeding. |
I wonder if it could make sense to add a WIP section to the index and insert those proposals that are in active discussion. If only to avoid the rrt build failed noise. Thumbs up, thumbs down? |
It is not possible to build without error in the presence of a document that is not in the index. In order for CS not to fail for PRs that include a new, not-yet-approved doc, adding an index section where they can be safely linked. See: #4560 (comment)
You can now link your doc to the WIP section to get rid of the CI grumbling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tzaeschke)
@jiceatscion I am unclear about the process. Can you tell me what I am meant to do? |
I am a bit unclear about the process as well to be honest. Matthias had defined it very well on an abstract basis: Your design is in the final review state. The process says: "
" However it doesn't describe the mechanics after that. Should we use the PR as a vehicle for discussions and refinement? That would mean that the doc should never be submitted before the final approval. Not sure that would be the best. As long as the design is marked W-I-P submitting it would be OK, so more than one person can make changes to the design text. Thoughts? Anyone? |
Proposal for NAT address discovery. Original discussion: #4517