Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper: Echostack: A flexible and scalable open-source software toolbox for echosounder data processing #913

Merged
merged 17 commits into from
Sep 25, 2024

Conversation

leewujung
Copy link
Contributor

@leewujung leewujung commented May 31, 2024

If you are creating this PR in order to submit a draft of your paper, please name your PR with Paper: <title>. An editor will then add a paper label and GitHub Actions will be run to check and build your paper.

See the project readme for more information.

Editor: Meghann Agarwal @mepa

Reviewers:

@hongsupshin hongsupshin added the paper This indicates that the PR in question is a paper label May 31, 2024
Copy link

github-actions bot commented May 31, 2024

Curvenote Preview

Directory Preview Checks Updated (UTC)
papers/wu-jung_lee 🔍 Inspect 95 checks passed (1 optional) Aug 6, 2024, 4:17 PM

@leewujung
Copy link
Contributor Author

leewujung commented Jun 1, 2024

One of the papers cited does not have a DOI, so the checks keep on failing. I also replaced a couple bibtex items for websites with direct URL (since they also don't have DOIs), but feel it may still be better to cite them as bibtex items, otherwise the same URL gets repeated more than once, which feels a little bizarre.

@hongsupshin: Are these check failings ok, or could you suggest how to address them? Thanks!

Update: Just saw the option to explicitly ignore the doi-exists check in myst.yml, so this is resolved! :)

@ameyxd
Copy link
Contributor

ameyxd commented Jun 4, 2024

great, thanks @leewujung

@ameyxd ameyxd assigned ameyxd and unassigned ameyxd Jun 10, 2024
@mepa
Copy link
Member

mepa commented Jun 28, 2024

Hi @chuchugo and @AshwinHegde! In case a little extra time is needed, the initial complete review deadline has been extended to next Wednesday, July 3rd.

@aterrel
Copy link
Collaborator

aterrel commented Jul 3, 2024

Howdy! I agreed to review this paper and will get a review in by July 8th.

@mepa
Copy link
Member

mepa commented Jul 3, 2024

Howdy! I agreed to review this paper and will get a review in by July 8th.

Thank you, @aterrel!

@mepa
Copy link
Member

mepa commented Jul 3, 2024

the initial complete review deadline has been extended to next Wednesday, July 3rd.

Update: the Proceedings Committee has extended the initial complete review deadline to Monday, July 8th.

@aterrel
Copy link
Collaborator

aterrel commented Jul 9, 2024

Independent Review Report

Reviewer: Andy R. Terrel

Department/Center/Division: Compute Products

Institution/University/Company: NVIDIA

Field of interest / expertise: Computer Science / Computational Math

Country: USA

Article reviewed: Echostack: A flexible and scalable open-source software toolbox for echosounder data processing

GENERAL EVALUATION

Please rate the paper using the following criteria (please use the abbreviation
to the right of the description)::

below doesn't meet standards for academic publication
meets meets or exceeds the standards for academic publication
n/a not applicable

  • Quality of the approach: meets

  • Quality of the writing: meets

  • Quality of the figures/tables: meets

SPECIFIC EVALUATION

  • Is the code made publicly available and does the article sufficiently
    describe how to access it? We aim not to publish papers that essentially
    advertise proprietary software. Therefore, if the code is not publicly
    available, please provide a one- to two- sentence response to each of the
    following questions:

Yes

  • Does the article present the problem in an appropriate context?
    Specifically, does it:

Yes this was a well written exposition of the stack needed for modern scientific computing. As someone who has built many systems of this nature, I think the authors did a marvelous job motivating and explaining all the pieces.

  • Is the content of the paper accessible to a computational scientist
    with no specific knowledge in the given field?

Yes

  • Does the paper describe a well-formulated scientific or technical
    achievement?

Yes, creating a usable software stack for this domain is an accomplishment.

  • Are the technical and scientific decisions well-motivated and
    clearly explained?

Yes

  • Are the code examples (if any) sound, clear, and well-written?

No code samples

  • Is the paper factually correct?

Yes

  • Is the language and grammar of sufficient quality?

Yes

  • Are the conclusions justified?

Yes

  • Is prior work properly and fully cited?

I'm not an expert on the domain but the citations were plentiful for me to follow the factual reasoning

  • Should any part of the article be shortened or expanded? Please explain.

No, it is just right.

  • In your view, is the paper fit for publication in the conference proceedings?
    Please suggest specific improvements and indicate whether you think the
    article needs a significant rewrite (rather than a minor revision).

Yes it is fit for publication.

Copy link
Collaborator

@AshwinHegde AshwinHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Paper reviewed: Echostack: A flexible and scalable open-source software toolbox for echosounder data processing
Reviewer: Ashwin Hegde

The paper introduces a suite of open source python packages, collectively called Echostack, that can be used for echosounder data processing, analysis, visualization, and workflow orchestration. The development is an ongoing effort and the paper serves as an interim report that outlines the motivation, describes the current capabilities of the set of tools and proposes future development directions.

The paper is very well written. The motivation for the work is clearly outlined upfront with clear pain points in existing workflows identified. The presentation of design principles for the software packages is appreciated. The solution is also introduced well. Even though I don't work in this domain, the presentation was easy to follow. The authors outline the functionalities of each of the packages well, also providing example use cases integrating different subsets of them. It would have been useful to provide code examples/tutorials as part of each of the package repositories but this is promised as part of future work. All figures are clear, captioned, and referenced correctly.

The work presented here seems highly relevant and directly impactful to the fisheries acoustics, ocean sciences, and environmental science communities. Since the packages are built in a modular way, some of these could be extended to broader disciplines, eg: geology and geophysics, archaelogy, hydrology, etc. Usage of the software is explained well and augmented with multiple examples. All the packages have separate repositories with easy to follow installation instructions for different environments.

The authors provide permissive open licenses for the packages and encourage open contribution which is great for the community.

Overall, I believe the Echostack suite is a significant advance in the processing, analysis, and visualization of echosounder data. The authors have done a good job of presenting the motivations, and proposing a well-structured solution. Apart from what I believe to be minor typos, I recommend publication without modification.

@leewujung
Copy link
Contributor Author

Thanks very much @aterrel and @AshwinHegde for reviewing this article! I have corrected the typos you have noted, and will do another couple thorough reads to make sure any other small things get caught.

@mepa
Copy link
Member

mepa commented Sep 2, 2024

Hi @aterrel and @AshwinHegde - Do you feel that this paper in its current form is ready for inclusion in the Proceedings?

The final reviewer decision deadline is September 9th so I'm just checking in to confirm reviewer decisions as that deadline approaches.

@mepa
Copy link
Member

mepa commented Sep 10, 2024

Reviewer sign-off is inferred from statements in the comments above.
From @aterrel:

"Yes it is fit for publication."

From @AshwinHegde:

"Apart from what I believe to be minor typos, I recommend publication without modification."

Thank you both for reviewing!

@cbcunc cbcunc merged commit fbc7a96 into scipy-conference:2024 Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paper This indicates that the PR in question is a paper ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants