-
-
Notifications
You must be signed in to change notification settings - Fork 116
2022 03 30 Sort package member
Sebastien edited this page Mar 30, 2022
·
1 revision
- Status: accepted
- Date: 2022-03-30
Technical Story: #279
Issue where raised #278 about having a different package member order when executing the command on Windows vs Linux
The code were sorting using sort()
without passing comparison method.
- sort consistently accross environment
- performance
- use
Intl.Compare
- use
localeCompare
Chosen option: "use Ìntl.Compare", because it is better in term of performance, more portable and it handles the locale as
localeCompare`.
- Package member generation is consistent
- Issue is fixed
None
- Good, because it has better performance
- Good, because it is more portable
- Good, because of locale handling
- Good, because of locale handling
- Bad, because of portability
- Bad, because of performance