Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Retry #15

wants to merge 2 commits into from

Conversation

alexplevako
Copy link
Contributor

No description provided.

@alexplevako alexplevako requested a review from kostassh February 15, 2022 17:34
}

p.client = scorumgo.NewClient(withRetry(transport, p.retryTimeout, p.retryLimit))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt withRetry be an option too?

@@ -163,7 +199,7 @@ func (p *Provider) Provide(ctx context.Context, from, irreversibleFrom uint32, e
sort.Slice(nums, func(i, j int) bool { return nums[i] < nums[j] })

for _, num := range nums {
p.CurrentBlockNum = num
atomic.StoreUint32(&p.currentBlockNum, num)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnt event-provider synced? why do we need atomic here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's not concurrent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants