-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry #15
base: master
Are you sure you want to change the base?
Retry #15
Conversation
} | ||
|
||
p.client = scorumgo.NewClient(withRetry(transport, p.retryTimeout, p.retryLimit)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldnt withRetry be an option too?
@@ -163,7 +199,7 @@ func (p *Provider) Provide(ctx context.Context, from, irreversibleFrom uint32, e | |||
sort.Slice(nums, func(i, j int) bool { return nums[i] < nums[j] }) | |||
|
|||
for _, num := range nums { | |||
p.CurrentBlockNum = num | |||
atomic.StoreUint32(&p.currentBlockNum, num) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isnt event-provider synced? why do we need atomic here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's not concurrent
No description provided.