Closed
Conversation
scottrigby
force-pushed
the
hip-chart-defined-plugins
branch
2 times, most recently
from
a79ec7e to
f7893b5
Compare
Update the SDK API Requirements section to reflect the reference implementation PluginRenderer struct: - ContentCachePath (string path) instead of ContentCache interface - PreloadedPlugins as raw bytes, not pre-compiled modules - Add explicit requirements for non-writable filesystems Signed-off-by: Scott Rigby <scott@r6by.com>
scottrigby
force-pushed
the
hip-chart-defined-plugins
branch
from
f7893b5 to
83c1fac
Compare
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
gjenkins8
force-pushed
the
gjenkins/hip-chart-defined-plugins
branch
from
7027371 to
5f3986e
Compare
scottrigby
force-pushed
the
hip-chart-defined-plugins
branch
from
83c1fac to
fa29091
Compare
Owner
|
this branch is updated to address all of your suggestions (branch is for helm#433). the render/v1 naming suggestion you made here was already a HIP in progress - I like the naming suggestion so updated that HIP. that is broken out into a separate HIP now: helm#434 very out of date now, so closing this. can reopen if you want to make more suggestions this way. thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.