Skip to content

Fix knex support & tests #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ghost wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Fix knex support & tests #251

ghost wants to merge 13 commits into from

Conversation

@ghost
Copy link

@ghost ghost commented Oct 12, 2020

A PR to mirror & improve the work done in #249

@ghost ghost marked this pull request as ready for review October 12, 2020 16:08
vados-scout added 2 commits October 13, 2020 01:10
Ensure integration tests run all files underneath
5dcebe7
Remove MySQL2 test
a07006a 
- Work to debug mysql2 knex support has moved to branch knex-with-mysql
@ghost
Copy link
Author

ghost commented Oct 12, 2020 •
edited by ghost
Loading

It looks like mysql2 support for knex is much hairier than mysql -- while I work on that, support for mysql and pg looks good so I'll push those out to an rc so they're usable ASAP

[EDIT] - only mysql is working properly but the issue for mysql2 has been found -- I'm going to go ahead and release them all together rather than only having partial knex support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants