Switch from Chrome-specific API to browser-agnostic API #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from the
chrome
api to thebrowser
API, with thewebextensions-polyfill
library acting as a polyfill for Chrome (which doesn't implement the WebExtensions API directly). This will enable the extension to work on all browsers except for Safari.This PR also cleans up the JS a little bit.
This PR requires #8 but merges into master, so after #8 is merged, the base branch should be changed to master.
Later, we'll need to work out signing for Firefox addons, as unsigned extensions are blocked from being added to the browser (they can only be added to Developer Edition and even then only after toggling a config flag). There are a lot of hoops to jump through. In the meantime, the extension can be tested on Firefox Developer Edition by setting
xpinstall.signatures.required
tofalse
inabout:config
.