Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Add named sections #5

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add named sections #5

wants to merge 1 commit into from

Conversation

rossjrw
Copy link
Member

@rossjrw rossjrw commented Jul 1, 2020

Copy link
Contributor

@danieltharp danieltharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and make the relevant changes in the render class as well.

@rossjrw
Copy link
Member Author

rossjrw commented Jul 1, 2020

For sure, this isn't close to finished. I'm anticipating there's going to be a bunch of stuff to change on wikidot's side as well.

@rossjrw
Copy link
Member Author

rossjrw commented Jul 1, 2020

https://github.com/scpwiki/wikidot/blob/3c5346ab0228e914e89c99881ac61013f418c6ed/php/modules/list/ListPagesModule.php#L565

            $this->_tmpSplitSource = preg_split('/^([=]{4,})$/m', $source);

Really, wikidot?

The separator detection is duplicated between text_wiki and other parts of the codebase that need different sections. Listpages lliterally reads the page content looking for ==== and splits the text.

I could go ahead and change what listpages is looking for, but how can I be sure that it's the only part of the codebase that does this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants