[WJ-1145] Add initial redis support #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't fix the redis warning, so I'll just get rid of this.
just add #[derive(Debug)] please, it's not that hard
Permits local connections when hosted in Docker.
Rsmq is single-connection and so cannot be be cloned, which given that it requires &mut is a problem. MultiplexedRsmq can be cloned since it has a series of connections underneath, so it can be cloned, and the &mut requirement in the trait is not an issue.
Only exists for local, similar to minio for S3.
Since we were missing it and it's another local-only container workflow.
emmiegit
commented
Oct 24, 2023
| pub localizations: Localizations, | ||
| pub mime_analyzer: MimeAnalyzer, | ||
| pub job_queue: JobQueue, | ||
| pub s3_bucket: Bucket, | ||
| } | ||
|
|
||
| impl Debug for ServerStateInner { |
There was a problem hiding this comment.
redis::ai::ConnectionManager is not Debug
Since these builds use local paths only, instead of full-repo context, this is the correct way to set context for these builds.
Codecov Report
@@ Coverage Diff @@
## develop #1668 +/- ##
===========================================
- Coverage 40.65% 40.50% -0.16%
===========================================
Files 338 340 +2
Lines 10641 10678 +37
===========================================
- Hits 4326 4325 -1
- Misses 6315 6353 +38
*This pull request uses carry forward flags. Click here to find out more.
|
Yossipossi1
approved these changes
Oct 24, 2023
|
The lint failure is Clippy complaining about unused imports it previously didn't care about. Going to ignore for now since it's unimportant, will fix later. |
|
thanks @Yossipossi1 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Redis support to DEEPWELL, secrets retrieval, a local Redis container (similar to minio) for development, and the GitHub workflows for redis and minio.
I ensure DEEPWELL builds with Redis, and the
pingmethod now checks for the Redis connection in addition to the existing Postgres connection check.